-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework heatmap permissions #14080
Merged
Merged
rework heatmap permissions #14080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now uses the same permission model as for the activity feed: only include activities in repos, that the doer has access to. this might be somewhat slower. - also improves handling of user.KeepActivityPrivate (still shows the heatmap to self & admins)
Codecov Report
@@ Coverage Diff @@
## master #14080 +/- ##
==========================================
+ Coverage 42.32% 42.35% +0.02%
==========================================
Files 726 726
Lines 77689 77709 +20
==========================================
+ Hits 32884 32913 +29
+ Misses 39405 39401 -4
+ Partials 5400 5395 -5
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Dec 21, 2020
6543
reviewed
Dec 21, 2020
6543
approved these changes
Dec 21, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Dec 21, 2020
lunny
approved these changes
Dec 21, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Dec 21, 2020
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only include activities in repos, that the doer has access to.
this might be somewhat slower.
user.KeepActivityPrivate
(still show the heatmap to self & admins)fixes #14066, fixes #14086