-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue template addition: Are you using Gitea behind CloudFlare? #14098
Issue template addition: Are you using Gitea behind CloudFlare? #14098
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14098 +/- ##
=======================================
Coverage 42.34% 42.34%
=======================================
Files 726 726
Lines 77741 77741
=======================================
+ Hits 32918 32923 +5
+ Misses 39421 39416 -5
Partials 5402 5402
Continue to review full report at Codecov.
|
The issues is putting anything in front of Gitea because now there is another layer involved which can modify content generated by Gitea. This is less often related to using a CDN and is an issue with using a proxy in general. Many of the issues (and problems in discord) are because of a nginx/apache/etc.. Misconfiguration and things like that (CloudFlare proxy settings too). The linked example isn't related to a stale cache or the CDN feature of CloudFlare but rather something that modifies the content Gitea sends before it reaches a browser. I think a maybe more general |
the stale cache part doesn't apply here, you're right. |
since more often than not CF appears to serve stale cache and cause troubles, I'd argue it might be helpful to ask about it in this here issue template
* as per @techknowlogick's suggestion * [skip ci]
* implement @mrsdizzie's suggestion * as the comment grows, rather span multiple lines * Gitea --> gitea to match case used in the rest of the template
a6205ad
to
c2ac6b7
Compare
I think it might be helpful to add something to the FAQ here. The referenced issue was specifically due to the AutoMinify option on Cloudfare causing whitespace changes. This option needs some way to say to say in that in this element whitespace actually matters and although any such marker would be non-standard I would argue it would be useful but until they provide that it simply cannot be used on Gitea - (until that is we move to an AJAX based diff scheme which would nicely resolve this) I'm not certain if there's any way other way we could mitigate. |
What exactly should be added to the FAQ?
|
Nothing special about CF's minifier, it's us that are breaking norms by not putting code in |
Please attach FAQ link on how to disable it on CF and specifically mention it's for HTML only, the options for JS and CSS are separate. |
Would sticking the spaces in a |
I'd say we just replace one of the parent BTW, GitHub would be broken too behind Cloudflare, they also have no As for this issue, I don't think we should pollute the issue template more. Less is more. |
If nobody against, I think this could be merged. |
ping |
As title.
Since more often than not CF appears to serve stale cache and cause troubles (such as here - 14089 and initially also here, although we found out about the CF part in our Discord chat), I'd argue it might be helpful to ask about it in this here issue template, hence this PR.