Display current stopwatch in navbar

[noerw]

Adds link to currently tracking issue into navbar
This also requires to extend the API response for stopwatches with the current tracked duration

fixes #4378

[noerw]

Possible alternative UI (but I don't really have the patience to fix this layout proper 🙃):

[lunny]

But if you start watch serval issues, how to display them?

[silverwind]

I would just display a single clock icon and make a hover dialog similar to what was done in #13977 to display the running trackers. Keep colors neutral, e.g. link to issue left aligned, time right-aligned.

[bobemoe]

Since #10533 there can be only one stopwatch.

[lunny]

Since #10533 there can be only one stopwatch.

Missed that.

[bobemoe]

With this new functionality it would make managing multiple stopwatches much easier, I wouldn't be opposed to reverting #10533, or maybe implementing it as an config option as suggested in that PR? Personally I cant really see a use case for multiple tracking.

Could the current sidebar stopwatch message be removed once this navbar version is implemented? Especially if multiple stopwatches get reimplemented as its a bit confusing, see #10529

[lunny]

With this new functionality it would make managing multiple stopwatches much easier, I wouldn't be opposed to reverting #10533, or maybe implementing it as an config option as suggested in that PR? Personally I cant really see a use case for multiple tracking.

Could the current sidebar stopwatch message be removed once this navbar version is implemented? Especially if multiple stopwatches get reimplemented as its a bit confusing, see #10529

I agree with you. I don't think #10533 needs to be reverted. A config option will make the things complicated.

[lunny]

CI failed is related.

[noerw]

I changed the UI with suggestions by @silverwind, I think it's good now:

@bobemoe As long as there is a single timer, that notice should stay. Also I can certainly see usecases for multiple timers: tracking a specific issue for billing, and the general topic you're spending time with for personal overview. If we re-enable that, this will be in a separate PR.

edit: not sure what's going on with the test failure, seems unrelated to my changes? 🤔

[silverwind]

Looks nice. Can we maybe also live-update the displayed time in the dialog, using JS loop that updates it every second?

[noerw]

I added clientside live updates to the displayed time, but it's somewhat janky due to client/serverside synchroniziation / drift.
If you think that it's still good-enough, this PR is ready from my side.

[codecov-io]

Codecov Report

Merging #14122 (34d03ae) into master (56a8929) will increase coverage by 0.00%.
The diff coverage is 68.96%.

@@           Coverage Diff           @@
##           master   #14122   +/-   ##
=======================================
  Coverage   41.86%   41.87%           
=======================================
  Files         745      745           
  Lines       79837    79866   +29     
=======================================
+ Hits        33421    33440   +19     
- Misses      40893    40899    +6     
- Partials     5523     5527    +4     

Impacted Files	Coverage Δ
routers/repo/issue_stopwatch.go	49.01% <59.09%> (+7.64%)	⬆️
models/issue_stopwatch.go	71.42% <100.00%> (+1.05%)	⬆️
modules/convert/issue.go	87.59% <100.00%> (+0.19%)	⬆️
routers/routes/macaron.go	93.26% <100.00%> (+<0.01%)	⬆️
modules/context/context.go	55.31% <0.00%> (-2.66%)	⬇️
routers/repo/repo.go	30.12% <0.00%> (-2.52%)	⬇️
modules/log/file.go	73.60% <0.00%> (-1.61%)	⬇️
models/issue.go	57.14% <0.00%> (+0.33%)	⬆️
routers/repo/view.go	41.58% <0.00%> (+0.62%)	⬆️
modules/queue/workerpool.go	60.00% <0.00%> (+1.22%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a8929...34d03ae. Read the comment docs.