Use MAINTAINERS file in repository in CONTRIBUTING #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about a relative link, so to be fully followed offline ?
|
tboerger
added
the
lgtm/need 2
tboerger
reviewed
Apr 14, 2017
| @@ -81,7 +81,7 @@ The current release cycle is aligned to start on December 25 to February 24, nex | |||
|
|
|||
| ## Maintainers | |||
|
|
|||
| To make sure every PR is checked, we have [team maintainers](https://github.com/orgs/go-gitea/teams/maintainers). Every PR **MUST** be reviewed by at least two maintainers (or owners) before it can get merged. A maintainer should be a contributor of Gitea (or Gogs) and contributed at least 4 accepted PRs. A contributor should apply as a maintainer in the [Gitter develop channel](https://gitter.im/go-gitea/develop). The owners or the team maintainers may invite the contributor. A maintainer should spend some time on code reviews. If a maintainer has no time to do that, they should apply to leave the maintainers team and we will give them the honor of being a member of the [advisors team](https://github.com/orgs/go-gitea/teams/advisors). Of course, if an advisor has time to code review, we will gladly welcome them back to the maintainers team. If a maintainer is inactive for more than 3 months and forgets to leave the maintainers team, the owners may move him or her from the maintainers team to the advisors team. | |||
| To make sure every PR is checked, we have [team maintainers](MAINTAINERS). Every PR **MUST** be reviewed by at least two maintainers (or owners) before it can get merged. A maintainer should be a contributor of Gitea (or Gogs) and contributed at least 4 accepted PRs. A contributor should apply as a maintainer in the [Gitter develop channel](https://gitter.im/go-gitea/develop). The owners or the team maintainers may invite the contributor. A maintainer should spend some time on code reviews. If a maintainer has no time to do that, they should apply to leave the maintainers team and we will give them the honor of being a member of the [advisors team](https://github.com/orgs/go-gitea/teams/advisors). Of course, if an advisor has time to code review, we will gladly welcome them back to the maintainers team. If a maintainer is inactive for more than 3 months and forgets to leave the maintainers team, the owners may move him or her from the maintainers team to the advisors team. | |||
There was a problem hiding this comment.
Please link absolutely to the master branch
There was a problem hiding this comment.
like ../master/MAINTAINERS ?
There was a problem hiding this comment.
All relative link don't use reference to branch like : [DCO](DCO) or [CONTRIBUTING](CONTRIBUTING.md). And the goal to use relative was to make it available offline. I don't think that ../master/MAINTAINERS would work outside github.
There was a problem hiding this comment.
Using an absolute link makes sure somebody is looking to the real source. Only the file on the master branch is valid
There was a problem hiding this comment.
All link that refer to local file are relative in the doc like : [DCO](DCO) or [CONTRIBUTING](CONTRIBUTING.md).
Personally, I have a little preference to relative link since it would work "offline" and it is not really important if your local copy is outdated because you know that your local copy reflect a historical version.
But relative link is also good and I understand the point of always refer to last version.
Maybe a vote is needed?
|
Agreed, [MAINTAINER] is the way to go.
BTW, these single-line paragraphs make reading diffs from a text only
MUA or browser *really* hard. I hope we'll start wrapping text to 70
cols or so soon...
|
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
appleboy
approved these changes
Apr 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because teams are not publicly available.
I just change maintainer link and not advisor one since there is no file for it.