Stop calling WriteHeader in Write #15862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header should be written before the first write. Fixes http: superfluous response.WriteHeader call from code.gitea.io/gitea/modules/context.(*Response).WriteHeader (response.go:67) Signed-off-by: Andrew Thornton <[email protected]>
noerw
reviewed
May 13, 2021
GiteaBot
added
the
lgtm/need 2
zeripath
commented
May 13, 2021
noerw
approved these changes
May 13, 2021
GiteaBot
added
lgtm/need 1
|
hmm... this is wrong and breaks tests... |
implementations will always do it for us Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #15862 +/- ##
==========================================
- Coverage 44.00% 44.00% -0.01%
==========================================
Files 681 681
Lines 82253 82253
==========================================
- Hits 36198 36193 -5
- Misses 40147 40153 +6
+ Partials 5908 5907 -1
Continue to review full report at Codecov.
|
lunny
reviewed
May 14, 2021
| @@ -49,7 +49,7 @@ func (r *Response) Write(bs []byte) (int, error) { | |||
| return size, err | |||
| } | |||
| if r.status == 0 { | |||
There was a problem hiding this comment.
So that breaks tests somehow as it results in breaking the contenttype detection.
Go will now always ensure that the header is written before it writes so I don't think we need the writeheader anymore
zeripath
changed the title
lafriks
approved these changes
May 14, 2021
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 14, 2021
Backport go-gitea#15862 Fixes http: superfluous response.WriteHeader call from code.gitea.io/gitea/modules/context.(*Response).WriteHeader (response.go:67) * Looking again we don't need this writeHeader as all of our downstream implementations will always do it for us Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lauris BH <[email protected]>
zeripath
added a commit
that referenced
this pull request
May 14, 2021
Backport #15862 Fixes http: superfluous response.WriteHeader call from code.gitea.io/gitea/modules/context.(*Response).WriteHeader (response.go:67) * Looking again we don't need this writeHeader as all of our downstream implementations will always do it for us Signed-off-by: Andrew Thornton <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Fixes http: superfluous response.WriteHeader call from code.gitea.io/gitea/modules/context.(*Response).WriteHeader (response.go:67) * Looking again we don't need this writeHeader as all of our downstream implementations will always do it for us Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go's write function will do it for us anyway
Fixes http: superfluous response.WriteHeader call from code.gitea.io/gitea/modules/context.(*Response).WriteHeader (response.go:67)
Signed-off-by: Andrew Thornton [email protected]