Merge all deleteBranch as one function and also fix bug when delete branch don't close related PRs #16067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
changed the title
jpraet
reviewed
Jun 4, 2021
| return err | ||
| } | ||
|
|
||
| if err := pull_service.CloseBranchPulls(doer, repo.ID, branchName); err != nil { |
There was a problem hiding this comment.
CloseBranchPulls is already called in PushUpdate here:
gitea/services/repository/push.go
Line 216 in ab77a24
There was a problem hiding this comment.
Yes, but it's safe to run it twice and there is slight performance reduce. The invoke in push.go will be invoked from both git command and DeleteBranch and others.
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Jun 5, 2021
GiteaBot
added
lgtm/need 1
lunny
force-pushed
the
lunny/fix_cleanuppullrequest
branch
from
514aeac to
cfc0fda
Compare
Codecov Report
@@ Coverage Diff @@
## main #16067 +/- ##
==========================================
- Coverage 44.19% 44.17% -0.03%
==========================================
Files 683 684 +1
Lines 82375 82335 -40
==========================================
- Hits 36409 36373 -36
- Misses 40071 40074 +3
+ Partials 5895 5888 -7
Continue to review full report at Codecov.
|
lafriks
approved these changes
Jun 7, 2021
GiteaBot
added
lgtm/done
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jun 7, 2021
…ranch don't close related PRs (go-gitea#16067) * Fix bug when delete branch don't close related PRs * Merge all deletebranch as one method * Add missed branch.go * fix comment Co-authored-by: Lauris BH <[email protected]>
6543
pushed a commit
that referenced
this pull request
Jun 7, 2021
…ranch don't close related PRs (#16067) (#16097) * Fix bug when delete branch don't close related PRs * Merge all deletebranch as one method Co-authored-by: Lauris BH <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
…ranch don't close related PRs (go-gitea#16067) * Fix bug when delete branch don't close related PRs * Merge all deletebranch as one method * Add missed branch.go * fix comment Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.