-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue template form #16349
Issue template form #16349
Conversation
This issue template has been based off of the current issue creation workflow defined in the ISSUE_TEMPLATE.md file This commit allows for that issue template (which is a legacy method of creating an issue) to be deleted
This commit deletes the old issue template file, as it is both legacy and replaced by ISSUE_TEMPLATE/issue.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👍
Removed most requirements Updated prompt to include instruction to state whether using try.gitea.io Added default value to Gitea version
Thank you for the feedback @delvh - I believe I have addressed your comments in my most recent commit. The test repository has also been updated with the latest version of this template. Please let me know if you have any further input. |
Just had a thought - Would there be any further issue types that would require more specific information or additional information? With the new issue template system, it is possible to customise the experience for the user depending on the type of error they are experiencing. It is also possible to use labels in the templates, which would be added depending on the form that's submitted. |
Yes, while that is definitely possible and should be implemented sometime, I think that's beyond the scope of this PR. |
If we're changing the workflow for creating issues in this PR, I feel like it might be worth making all the changes in this PR to avoid multiple PRs for a similar issue. |
Well okay, then I would first recommend a second template for Feature Requests. |
I've gone ahead and put the feature request form onto the testing repository as well as this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## main #16349 +/- ##
==========================================
- Coverage 45.22% 45.22% -0.01%
==========================================
Files 766 766
Lines 86716 86716
==========================================
- Hits 39217 39214 -3
- Misses 41148 41151 +3
Partials 6351 6351
Continue to review full report at Codecov.
|
Co-authored-by: a1012112796 <[email protected]>
Also, it might be nice to setup the following in the config.yml: contact_links:
- name: Security issues
url/mail: [email protected]
about: If your issue is security related, please write a mail to [email protected] instead of opening an issue Or something similar, so that the user does not even get the idea to open a public security related issue. |
I would have to use |
It appears there's a URL parser that validates that the URL is indeed a web URL (e.g. prefixed with As a result, I don't believe that what you're suggesting is possible. |
That's a pity. This approach would have been much more intuitive than hiding that information inside the bug report as a comment… Who knows, maybe one day GitHub will add this as well? |
It is less than ideal. However I'm hoping that by positioning the email address at the very top of the bug report form should get their attention. |
There is a banner that tells you to create a config.yml when you already have a config.yaml Renaming the file stops this from occurring.
Does anyone have any further input on this? |
This pull request removes the old file, located at .github/issue_template.md (this is a legacy method of defining issue templates).
The new method of creating an issue template also allows for forms to be created when users are submitting an issue. When creating the issue template, I have used the current issue template as closely as possible.
This pull request also disables blank issue creation, meaning that all new issues must use the form(s) configured to submit an issue.
This form can be tested by going to https://github.com/redstonedesigner/gitea-issue-form-testing and creating a new issue.