-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Fomantic's CSS tooltips #16974
Conversation
CSS-only tooltips suffer various issues with positioning and there was only one single instance of them in the templates. Replace that instance with a regular popup and exclude these `data-tooltip` styles from the Fomantic build.
3f45a54
to
b0a6ba5
Compare
@delvh included the rename perl -p -i -e 's#poping#popping#g' templates/**/* web_src/js/index.js |
If we are already at it: Is there a reason why these two are two separate classes? |
I think that class can probably be removed entirely. I'll probably move the renaming commit to another PR as it's not directly related. |
I am fine with both. |
20d636a
to
b0a6ba5
Compare
Backed out of the renaming change here, will follow up with a separate PR later. |
🚀 |
CSS-only tooltips suffer various issues with positioning and there was only one single instance of them in the templates. Replace that instance with a regular popup and exclude these
data-tooltip
styles from the Fomantic build.