Replace "unix" by "http+unix" for PROTOCOL

[mscherer]

Fixes #9318

[zeripath]

Edit I misread the pr I see that "unix" is still supported.

Misread

[zeripath]

Is this really worth doing?

I'd prefer if we could get host and port merged in to an ADDRESS value and then we'd be able to detect if we need to use a unix or a tcp port by the ADDRESS. Then protocol can drop all of the unix variants.

[mscherer]

I may be missing something, but a ADDRESS value wouldn't be sufficient, as you still need to specify if that's FCGI or HTTP (or a future protocol), no ?

[zeripath]

Yes you would still need the protocol field but the weird +unix variants would be unnecessary

[mscherer]

Yeah, I agree, this would be better. having each potential protocol being double is not elegant and would make doc more complex quite fast if a new protocol is added (eg, something to replace FastCGI).

[silverwind]

Keep note thathttps+unix is certainly also a possibility.

[wxiaoguang]

This change is fine to me.

zeripath's suggestion about "get host and port merged in to an ADDRESS" is pretty good.

So should we wait for the new work about unified ADDRESS, or get this PR merged first?

(I marked this PR as wip temporarily)

[mscherer]

I feel that the ADDRESS change would requires a longer design discussion.

[mscherer]

I rebased, but I think it requires a quick re-review

[wxiaoguang]

@zeripath @techknowlogick how do you think?

[wxiaoguang]

Bump. If still no objection in 2 days, maybe we can get this PR merged.

[zeripath]

yeah I think we should merge as is and address the address issue at another point.

[lunny]

Bump. If still no objection in 2 days, maybe we can get this PR merged.

So do you want to remove the wip label?