Update Changelog #18047
Merged
Update Changelog #18047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add:
* Move POST /{username}/action/{action} to simply POST /{username} (go-gitea#18045) (go-gitea#18046)
* Fix delete u2f keys bug (go-gitea#18040) (go-gitea#18042)
* Reset Session ID on login (go-gitea#18018) (go-gitea#18041)
* Prevent off-by-one error on comments on newly appended lines (go-gitea#18029) (go-gitea#18035)
Signed-off-by: Andrew Thornton <[email protected]>
jolheiser
approved these changes
Dec 20, 2021
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Dec 20, 2021
GiteaBot
added
lgtm/done
6543
approved these changes
Dec 20, 2021
rinsuki
reviewed
Dec 22, 2021
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| ################################### | |||
| #Build stage | |||
| FROM golang:1.16-alpine3.13 AS build-env | |||
| FROM techknowlogick/go:1.16-alpine3.13 AS build-env | |||
There was a problem hiding this comment.
why base image changed to techknowlogick's one?
I want to know background.
There was a problem hiding this comment.
The base alpine version of go has increased to at least 1.14.
We can't use that because if we do all the docker users who are running docker <20.10.16 will find that Gitea is broken because hooks will suddenly stop running.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
Signed-off-by: Andrew Thornton [email protected]