Consolidate boilerplate in integration tests #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
lafriks
reviewed
Jun 15, 2017
integrations/integration_test.go
Outdated
| ) | ||
| doc := NewHtmlParser(t, resp.Body) | ||
| req = NewRequestWithValues(t, "POST", "/user/login", map[string]string{ | ||
| "_csrf": doc.GetInputValueByName("_csrf"), |
There was a problem hiding this comment.
This should be changed to GetCSRF
lunny
reviewed
Jun 16, 2017
| @@ -155,21 +156,19 @@ func (s *TestSession) MakeRequest(t *testing.T, req *http.Request) *TestResponse | |||
| return resp | |||
| } | |||
|
|
|||
| func loginUser(t *testing.T, userName, password string) *TestSession { | |||
There was a problem hiding this comment.
No, I don't think we should do that. How should we test user login with different password?
There was a problem hiding this comment.
How about having two functions?
func loginUserDefaultPassword(...) {
loginUser(..., "password")
}
func loginUser(...) {
// what we originally had
}
|
@ethantkoenig Could you rebase the master? something wrong with drone sig file. |
ethantkoenig
force-pushed
the
refactor/integration_test
branch
from
d008849 to
d1603d3
Compare
|
@appleboy Rebased |
ethantkoenig
force-pushed
the
refactor/integration_test
branch
from
d1603d3 to
a84e002
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move error-checking and other shared boilerplate to helper functions; makes tests less verbose.