Fix owners cannot create organization repos bug #20841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
skip-changelog
GiteaBot
added
lgtm/need 2
Co-authored-by: Gusted <[email protected]>
Gusted
approved these changes
Aug 18, 2022
GiteaBot
added
lgtm/need 1
delvh
reviewed
Aug 18, 2022
Comment on lines
+419
to
+421
| t.CanCreateOrgRepo = form.CanCreateOrgRepo | ||
| } else { | ||
| t.CanCreateOrgRepo = true |
There was a problem hiding this comment.
Alternatively, to save a line, you can do
t.CanCreateOrgRepo = t.IsOwnerTeam()
if !t.CanCreateOrgRepo {
...
t.CanCreateOrgRepo = form.CanCreateOrgRepoabove
lafriks
approved these changes
Aug 18, 2022
GiteaBot
added
lgtm/done
delvh
approved these changes
Aug 18, 2022
|
Please send backport |
zeripath
pushed a commit
to zeripath/gitea
that referenced
this pull request
Aug 18, 2022
Backport go-gitea#20841 * Fix owners cannot create organization repos bug * Fix api * Update routers/api/v1/org/team.go Co-authored-by: Gusted <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
Aug 18, 2022
Backport #20841 * Fix owners cannot create organization repos bug * Fix api * Update routers/api/v1/org/team.go Co-authored-by: Gusted <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: Gusted <[email protected]> Co-authored-by: John Olheiser <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 19, 2022
* giteaofficial/main: Fix create repository page's help text (go-gitea#20810) In PushMirrorsIterate and MirrorsIterate if limit is negative do not set it (go-gitea#20837) Disable doctor logging on panic (go-gitea#20847) Remove calls to load Mirrors in user.Dashboard (go-gitea#20855) switch to node18 for snapcraft Prevent 500 is head repo does not have PullRequest unit in IsUserAllowedToUpdate (go-gitea#20839) Fix owners cannot create organization repos bug (go-gitea#20841)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
* Fix owners cannot create organization repos bug * Fix api * Update routers/api/v1/org/team.go Co-authored-by: Gusted <[email protected]> Co-authored-by: Gusted <[email protected]>
|
I would expect this is now fixed in the latest rootless Docker image of Gitea?
As org owner still get 403 Forbidden error when pressing the "New Repository" button on Org level. The request is a GET call on: |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20643, owners always can create repositories whatever given value.
If you encountered this problem, please upgrade Gitea and update the owner team and then owner team's permission will come back.