-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect REQUIRE_SIGNIN_VIEW
for packages
#20873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
reviewed
Aug 20, 2022
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Aug 20, 2022
silverwind
approved these changes
Sep 15, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Sep 15, 2022
lafriks
approved these changes
Sep 15, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Sep 15, 2022
wxiaoguang
approved these changes
Sep 21, 2022
KN4CK3R
added a commit
to KN4CK3R/gitea
that referenced
this pull request
Sep 21, 2022
Fix go-gitea#20863 When REQUIRE_SIGNIN_VIEW = true, even with public repositories, you can only see them after you login. The packages should not be accessed without login. Co-authored-by: Lauris BH <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 22, 2022
* upstream/main: Use absolute links in feeds (go-gitea#21229) Prevent invalid behavior for file reviewing when loading more files (go-gitea#21230) Respect `REQUIRE_SIGNIN_VIEW` for packages (go-gitea#20873) Make Clone in VSCode link get updated correctly (go-gitea#21225) Configure golangci-lint to show all issues (go-gitea#21106) Fix user visible check (go-gitea#21210) Fix template bug of admin monitor (go-gitea#21208) Clarify that `ENABLE_SWAGGER` only influences the API docs, not the routes (go-gitea#21215) Enable fluid page layout on medium size viewports (go-gitea#21178) [API] teamSearch show teams with no members if user is admin (go-gitea#21204)
wxiaoguang
added a commit
that referenced
this pull request
Sep 23, 2022
Backport of #20873 When REQUIRE_SIGNIN_VIEW = true, even with public repositories, you can only see them after you login. The packages should not be accessed without login. Co-authored-by: Lauris BH <[email protected]> Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/packages
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #20863