Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some small typos and corrected a filepath in the documentation #21322

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Fixed some small typos and corrected a filepath in the documentation #21322

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e667133
fixed some small typos and corrected a filepath in the documentation
rj1 Oct 3, 2022
3094214
Update guidelines-backend.md
wxiaoguang Oct 7, 2022
1c0aacc
Merge branch 'main' into main
wxiaoguang Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/content/doc/developers/guidelines-backend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Some actions should allow for rollback when database record insertion/update/del
So services must be allowed to create a database transaction. Here is some example,

```go
// servcies/repository/repo.go
// services/repository/repository.go
func CreateXXXX() error {\
ctx, committer, err := db.TxContext()
Copy link
Member

@delvh delvh Oct 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block can now be updated to use db.WithTx(…)
Should this be done in this PR as well?

if err != nil {
Expand Down Expand Up @@ -101,7 +101,7 @@ func UpdateIssue(ctx context.Context, repoID int64) error {
### Package Name

For the top level package, use a plural as package name, i.e. `services`, `models`, for sub packages, use singular,
i.e. `servcies/user`, `models/repository`.
i.e. `services/user`, `models/repository`.

### Import Alias

Expand Down