Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unit types commits and settings #2161

Merged
merged 4 commits into from
Jul 17, 2017
Merged

Remove unit types commits and settings #2161

merged 4 commits into from
Jul 17, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jul 13, 2017 •
edited
Loading

  • Remove unit type commits & settings as they were not working correctly anyway
  • Fix unit type checking as all unit types was always already set before loading user allowed unit types
  • Fix style so that when "Settings" tab is not visible would still be aligned more to left not in all width with lot of space in between tabs.
  • Fix RepoView3 test (user3 is organization and can not be used to log in)
  • Fix invalid unit test (user4 is in team1 so it must have access to repo3, changed test to user5)
  • Allow changing units only for teams with read or write access mode

@lafriks lafriks force-pushed the refactor_repo_tabs branch from bae52aa to b598607 Compare July 13, 2017 20:56
@lafriks lafriks added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jul 13, 2017
@lafriks lafriks force-pushed the refactor_repo_tabs branch 5 times, most recently from 7854784 to fa1b818 Compare July 14, 2017 00:58
@lafriks lafriks force-pushed the refactor_repo_tabs branch from fa1b818 to 275ca0b Compare July 14, 2017 01:06
@lafriks
Copy link
Member Author

lafriks commented Jul 14, 2017

/cc @lunny

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 14, 2017
@lafriks lafriks changed the title Remove unit type commits and use unit type code for commits tab Remove unit types commits and settings Jul 14, 2017
@lafriks lafriks requested a review from lunny July 14, 2017 01:20
@lafriks lafriks force-pushed the refactor_repo_tabs branch from 04166cf to 4f9d80a Compare July 14, 2017 02:19
@lafriks lafriks force-pushed the refactor_repo_tabs branch from 7344d6f to 33a01e5 Compare July 14, 2017 20:57
@lafriks
Copy link
Member Author

lafriks commented Jul 14, 2017

Code is ready for review

@lafriks
Copy link
Member Author

lafriks commented Jul 14, 2017 •
edited
Loading

FYI tests started to fail after I fixed units functionality thats why I fixed them in this PR

@lafriks lafriks added this to the 1.2.0 milestone Jul 14, 2017
@lunny
Copy link
Member

lunny commented Jul 15, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2017
@Bwko
Copy link
Member

Bwko commented Jul 16, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 16, 2017
@lunny lunny merged commit f33e6ae into go-gitea:master Jul 17, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lafriks @lunny @Bwko @tboerger