Temporarily patch go-ini/ini with fork #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
added
the
lgtm/need 2
|
Why not updating vendor to migrate to a temporary fork if the issue take to much time?(https://github.com/kardianos/govendor/blob/master/doc/faq.md#q-ive-forked-a-package-and-i-havent-upstreamed-the-changes-yet-what-should-i-do) |
ethantkoenig
force-pushed
the
fix/docker_ini
branch
from
3024567 to
2b45cdb
Compare
ethantkoenig
changed the title
|
I think that go-ini/ini fork with that change should be moved under gitea org |
|
@lafriks Done |
ethantkoenig
force-pushed
the
fix/docker_ini
branch
from
2b45cdb to
84534a6
Compare
|
LGTM |
tboerger
added
lgtm/need 1
7 tasks
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short-term fix for #2197.Fixing the underlying problem will involve changing theSaveTo(..)method in thego-ini/inipackage, but this will at leastLet Docker users run gitea in the meantimeMitigate the problem enough to not block the 1.2.0 releaseFixes #2197. Updates the
SaveTo(..)method in thego-ini/inipackage. For the sake of not blocking the 1.2.0 release, I've temporarily updated the dependency to a fork. Once the fix to theSaveTo(..)method is merged into the main repository (go-ini/ini#115), we can revert.