Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint fixed for modules/base #231

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 24, 2016

No description provided.

@lunny lunny added this to the 1.0.0 milestone Nov 24, 2016
@codecov-io
Copy link

codecov-io commented Nov 24, 2016

Current coverage is 3.03% (diff: 0.00%)

Merging #231 into master will increase coverage by <.01%

@@            master      #231   diff @@
========================================
  Files           33        33          
  Lines         8107      8106     -1   
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
+ Misses        7841      7840     -1   
  Partials        20        20          

Powered by Codecov. Last update 3917ed4...fb3bb69

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 24, 2016
@strk
Copy link
Member

strk commented Nov 24, 2016

LGTM but please try to keep comments as english phrases (This does that.)

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2016
@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2016
@tboerger tboerger merged commit 8ba0ac9 into go-gitea:master Nov 24, 2016
@lunny lunny deleted the lunny/golint_modules_base branch November 28, 2016 15:58
@lunny
Copy link
Member Author

lunny commented Nov 28, 2016

resolved #70

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants