Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint issue.go #234

Merged
merged 2 commits into from
Nov 24, 2016
Merged

Lint issue.go #234

merged 2 commits into from
Nov 24, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 24, 2016

Superceeds #215 improving it

@codecov-io
Copy link

Current coverage is 3.03% (diff: 0.00%)

Merging #234 into master will not change coverage

@@            master      #234   diff @@
========================================
  Files           33        33          
  Lines         8107      8107          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7841      7841          
  Partials        20        20          

Powered by Codecov. Last update 6ed7f26...8aa960f

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 24, 2016
@lunny lunny added this to the 1.0.0 milestone Nov 24, 2016
@lunny
Copy link
Member

lunny commented Nov 24, 2016

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. topic/code-linting and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2016
@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2016
@tboerger tboerger merged commit 0a66c2a into go-gitea:master Nov 24, 2016
@strk strk deleted the issue-lint branch November 24, 2016 10:41
@lunny
Copy link
Member

lunny commented Nov 28, 2016

resolved #70

ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 18, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants