Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some mistakes when using ignSignIn #24415

Merged
merged 9 commits into from
May 4, 2023
Merged

Fix some mistakes when using ignSignIn #24415

merged 9 commits into from
May 4, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 29, 2023 •
edited
Loading

Some old code doesn't respect the definition of RequireSignInView (the ignSignIn is forgotten).

After #24413, this PR will do more fixes, and rename the strange ignSignIn to optSignIn.

This PR is ready for review, I think we can postpone the "ignSignIn" renaming to another, to make this PR simple and clear.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2023
@silverwind
Copy link
Member

Can we refactor to readable requireSignIn and ignoreSignIn (assuming it stands for that?

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 29, 2023 •
edited
Loading

Can we refactor to readable requireSignIn and ignoreSignIn (assuming it stands for that?

ignore is still not that right. My idea is:

rename them to "optSignIn" ...
I think we can postpone the "ignSignIn" renaming to another, to make this PR simple and clear.

req vs opt seems clear enough, but let's do it in next PR, to keep this PR simple

@silverwind
Copy link
Member

Can we refactor to readable requireSignIn and ignoreSignIn (assuming it stands for that?

ignore is still not that right. My idea is:

rename them to "optSignIn" ...
I think we can postpone the "ignSignIn" renaming to another, to make this PR simple and clear.

req vs opt seems clear enough, but let's do it in next PR, to keep this PR simple

require and optional please. I hate pointless abbreviations in code.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 29, 2023 •
edited
Loading

require and optional please. I hate pointless abbreviations in code.

Really? You wrote df dib ..... (so I assumed that req and opt could be fine)

But next PR please (for the renaming)

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 29, 2023 •
edited
Loading

To get an agreement quickly, I started a vote in maintainer channel.

  1. "reqSIgnIn" vs "optSignIn" (optional)
  2. or use full name: "requireSignIn" vs "optionalSignIn"

@silverwind
Copy link
Member

silverwind commented Apr 29, 2023 •
edited
Loading

require and optional please. I hate pointless abbreviations in code.

Really? You wrote df dib ..... (so I assumed that req and opt could be fine)

But next PR please (for the renaming)

Yes, I'm guilty, but in the CSS helper case it had a performance benefit, in go code, naming of functions does not affect performance 😆

silverwind
silverwind approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would still like to see the function rename, but can be done in another PR.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2023
@lunny lunny added the type/bug label May 4, 2023
@lunny lunny added this to the 1.20.0 milestone May 4, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2023
@silverwind silverwind enabled auto-merge (squash) May 4, 2023 10:38
@silverwind silverwind merged commit 03fab6a into go-gitea:main May 4, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2023
@wxiaoguang wxiaoguang deleted the fix-check-sign-in branch May 4, 2023 12:10
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 5, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
43987ed 
* upstream/main:
  Harmonize title formatting in `docs/content/doc/development/api-usage.en-us.md` (go-gitea#24529)
  automate locking closed threads (go-gitea#24525)
  [skip ci] Updated translations via Crowdin
  Display warning when user try to rename default branch (go-gitea#24512)
  Upgrade to Node 20 on CI, enable actions cancellation (go-gitea#24524)
  Fix incorrectly quoted translation (go-gitea#24514)
  Fix color for transfer related buttons when having no permission to act (go-gitea#24510)
  Fix some mistakes when using `ignSignIn` (go-gitea#24415)
  Remove unused zapx replace statement on go.mod (go-gitea#24515)
  Don't display creating page button in a mirror wiki repository (go-gitea#24395)
  Improve template system and panic recovery (go-gitea#24461)
  Faster git.GetDivergingCommits (go-gitea#24482)
  Merge setting.InitXXX into one function with options (go-gitea#24389)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot