Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint models/update.go, release.go & webhook_slack.go #245

Merged
merged 2 commits into from
Nov 25, 2016

Conversation

Bwko
Copy link
Member

@Bwko Bwko commented Nov 24, 2016

No description provided.

@Bwko Bwko changed the title Lint models/update.go & webhook_slack.go Lint models/update.go, release.go & webhook_slack.go Nov 24, 2016
@strk
Copy link
Member

strk commented Nov 24, 2016

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 24, 2016
@andreynering
Copy link
Contributor

andreynering commented Nov 24, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 25, 2016
@@ -15,6 +15,7 @@ import (
"code.gitea.io/gitea/modules/log"
)

//UpdateTask defines an UpdateTask
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space behind //, on multiple places below as well.

@Bwko Bwko force-pushed the lint/update&slack branch from 6d3dda5 to 33a2ac3 Compare November 25, 2016 06:56
@tboerger tboerger merged commit 21b7d30 into go-gitea:master Nov 25, 2016
@Bwko Bwko deleted the lint/update&slack branch November 27, 2016 11:06
@lunny
Copy link
Member

lunny commented Nov 28, 2016

resolved #70

ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 18, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants