Show outdated comments in files changed tab #24936
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
sebastian-sauer
force-pushed
the
feature/24913_show_outdated_comments
branch
from
88bf017 to
f7be42e
Compare
|
Thanks @silverwind i've changed the label and applied your suggestions. I've updated the screenshots to show the latest version. |
|
I will restyle this a bit and then push those changes here. |
|
After latest fixes: 
Questions
|
|
Thanks - looks very good. Regarding icon - octicon-check is fine for me. These comments don't resolve, as an outdated comment is not automatically resolved (when adding lines at the beginning of a file it's quite possible that multiple comments in the same file will be outdated as the commit sha of the line is different) |
Okay, if it's always an concious action, we can restore the "Outdated" label again. Can you make it so the only difference between active and outdated comment is this label added after the text on the left side of that box? And yes, please change to checkmark, as that checkmark is there to indicate the resolved state. |
|
Do you mean like this:
|
|
I think a unresolved but outdated comment should not have this full width header. Can we remove it and instead put the "Outdated" label onto the first comment's header, left side of the "Review" label? 
This looses the ability to toggle, but I think it's more consistent to not have these toggleable. |
|
Sounds good. But where should we put the Show original link in this case? Just putting the link in front of the label doesn't look that good: |
|
You could make the label itself an |
|
|
don't show titlebar if comment is only outdated.
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
@sebastian-sauer please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.20. @sebastian-sauer, please send one manually. 🍵 |
GiteaBot
added
backport/manual
Backport go-gitea#24936 If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes go-gitea#24913 --------- Co-authored-by: silverwind <[email protected]>
Backport go-gitea#24936 If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes go-gitea#24913 --------- Co-authored-by: silverwind <[email protected]>
Backport in #25428 |
* origin/main: (47 commits) Move some regexp out of functions (go-gitea#25430) Show outdated comments in files changed tab (go-gitea#24936) Remove "CHARSET" config option for MySQL, always use "utf8mb4" (go-gitea#25413) Fine tune project board label colors and modal content background (go-gitea#25419) Fix missing commit message body when the message has leading newlines (go-gitea#25418) add python/poetry to devcontainer (go-gitea#25407) Refactor path & config system (go-gitea#25330) Add actor and status dropdowns to run list (go-gitea#25118) Use the new download domain replace the old (go-gitea#25405) Avoid polluting config file when "save" (go-gitea#25395) Fix dropdown icon layout on diff page (go-gitea#25397) Support configuration variables on Gitea Actions (go-gitea#24724) Substitute variables in path names of template repos too (go-gitea#25294) Navbar styling rework (go-gitea#25343) Fix blank dir message when uploading files from web editor (go-gitea#25391) Add git-lfs support to devcontainer (go-gitea#25385) Use qwtel.sqlite-viewer instead of alexcvzz.vscode-sqlite (go-gitea#25386) Use Actions git context instead of dynamically created buildkit one (go-gitea#25381) rename tributeValues to mentionValues (go-gitea#25375) Fix LDAP sync when Username Attribute is empty (go-gitea#25278) ...
Backport #24936 If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes #24913 Co-authored-by: silverwind <[email protected]>
|
Please tell me is this feature ("show outdated comments") available? |
|
Only for 1.21 which is not released yet. |
|
Thanks for fast reply ! |
If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on).
Screenshots
When resolved and outdated:
Option to enable/disable this (stored in user settings - default is disabled):
fixes #24913