Add CODEOWNERS feature #25060
Closed
Add CODEOWNERS feature #25060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users that exist are automatically requested as reviewers when a PR is created. Does not work for teams. Does not validate that the users are eligible to actually review the PR. Includes call to stub function in issue.go (line 216) to what will become the Parser.
Returns a list of individual owners and teams associated with changed files that are passed into it.
…ea#33) from CodeownersUnitTests into main Reviewed-on: https://git.etogy.internal/etogy/gitea/pulls/33
…sUnitTests into main Reviewed-on: https://git.etogy.internal/etogy/gitea/pulls/35
base for good refactoring
…om ihamm.RefactoringLineValidation into main Reviewed-on: https://git.etogy.internal/etogy/gitea/pulls/53
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
|
Duplicate of #24910? |
JakobDev
reviewed
Jun 3, 2023
There was a problem hiding this comment.
You should just set FileError. This is already implemented in Gitea, so you don't need this file.
Yeah. This one follows the GitHub CODEOWNERS syntax rules though, and it requires write access to be an owner. Shield icon on the files is helpful. |
|
Since #24910 merged, please update this PR. |
|
It's been a while since anyone on my team has looked at this. If any further changes are required to the CODEOWNERS feature (in either our implementation or the official implementation), it would be easier for all parties to create a new issue and work fresh from the latest version of Gitea. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to define code ownership in a CODEOWNERS file, similar to the GitHub feature. See the new docs page for a full feature description.
Closes #10161
Implementation
The primary back-end change is adding a call to
AddCodeownerReviewers()inservices/issue/issue.go. This searches the base repo for a valid CODEOWNERS file, parses it, and requests reviews from any users/teams that own any changed files in the PR. The parsing/validation is contained in functions withinservices/issue/codeowners.go.The applicable CODEOWNERS file is also parsed to:
UI Changes
Viewing a CODEOWNERS file with validation errors:
Editing a CODEOWNERS file with validation errors:
The remaining examples assume the following valid CODEOWNERS file is in the
mainbranch:Viewing a file that has an owner displays a shield icon that can be hovered over to show the ownership tooltip. If no owner applies to the file, the shield is not displayed:
When opening a PR, the same hoverable codeowner shield icon is visible for any changed files with owners:
Same thing when viewing a PR's changed files:
Same thing when viewing a commit:
Known issues and features we are still working on
codeowners.go