Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust style for action run list (align icons, adjust padding) #25170

Merged
merged 18 commits into from
Jun 12, 2023
Merged

Adjust style for action run list (align icons, adjust padding) #25170

merged 18 commits into from
Jun 12, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Jun 9, 2023 •
edited
Loading

Main changes:

  • Moved the icon into action-item-main, and make it position: absolute to allow add margin it to align with issue-item-top-row.
  • Adjusted padding and color of texts.

Before

Screen Shot 2023-06-09 at 17 04 38

After

Screen Shot 2023-06-09 at 18 32 47

On hover:

Screen Shot 2023-06-09 at 18 32 54

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 9, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2023
@HesterG HesterG added the topic/ui Change the appearance of the Gitea UI label Jun 9, 2023
@silverwind
Copy link
Member

silverwind commented Jun 9, 2023 •
edited
Loading

It does look better, thanks. I wonder if position: absolute can be avoided like we do on the issue/pr list.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 11, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 11, 2023
@lunny lunny enabled auto-merge (squash) June 12, 2023 09:29
@lunny lunny merged commit 06557a7 into go-gitea:main Jun 12, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 12, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 12, 2023
@HesterG HesterG deleted the adjust-actionlist branch June 16, 2023 00:50
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HesterG @silverwind @lunny @GiteaBot