Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fullscreen for action #25200

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Fix fullscreen for action #25200

merged 6 commits into from
Jun 12, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Jun 12, 2023

An error occurs when clicking on show full screen on action page.

Screen Shot 2023-06-12 at 13 06 52

class name has changed in #25134, so the selector is not working.
Enhance the selectors to fix this.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2023
@techknowlogick techknowlogick added type/bug backport/v1.20 This PR should be backported to Gitea 1.20 and removed backport/v1.20 This PR should be backported to Gitea 1.20 labels Jun 12, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2023
@delvh delvh added the backport/v1.20 This PR should be backported to Gitea 1.20 label Jun 12, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 12, 2023
@lunny lunny enabled auto-merge (squash) June 12, 2023 09:30
@lunny lunny merged commit 3318001 into go-gitea:main Jun 12, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 12, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 12, 2023
An error occurs when clicking on `show full screen` on action page.

<img width="1440" alt="Screen Shot 2023-06-12 at 13 06 52"
src="https://github.com/go-gitea/gitea/assets/17645053/1d4ded3c-fb77-4dd8-9201-24d0696f96eb">

class name has changed in go-gitea#25134, so the selector is not working. 
Enhance the selectors to fix this.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 12, 2023
silverwind pushed a commit that referenced this pull request Jun 12, 2023
Backport #25200 by @HesterG

An error occurs when clicking on `show full screen` on action page.

<img width="1440" alt="Screen Shot 2023-06-12 at 13 06 52"
src="https://github.com/go-gitea/gitea/assets/17645053/1d4ded3c-fb77-4dd8-9201-24d0696f96eb">


class name has changed in #25134, so the selector is not working. 
Enhance the selectors to fix this.

Co-authored-by: HesterG <[email protected]>
@HesterG HesterG deleted the fix-fullscreen branch June 13, 2023 10:15
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants