Use fetch to send requests to create issues/comments #25258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
issue-comment-ajax
branch
from
ab62cba to
15a6400
Compare
pull-request-size
bot
added
the
size/L
This was referenced Jun 14, 2023
|
You should check whether the content of issue/comment is empty |
There was no such check, so I think it's not in this PR's scope. |
lunny
approved these changes
Jun 15, 2023
GiteaBot
added
lgtm/need 1
HesterG
approved these changes
Jun 15, 2023
GiteaBot
added
lgtm/done
silverwind
approved these changes
Jun 16, 2023
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
pushed a commit
that referenced
this pull request
Aug 10, 2023
fix #26427 related #25258 --- Before:  --- After: 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #23290
Network error won't make content lost. And this is a much better approach than "loading-button".
The UI is not perfect and there are still some TODOs, they can be done in following PRs, not a must in this PR's scope.