Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make buttons in a modal form have proper type. (#25446) #25478

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Make buttons in a modal form have proper type. (#25446) #25478

merged 2 commits into from
Jun 24, 2023

Conversation

denyskon
Copy link
Member

Backport #25446 by @wxiaoguang

Fix #25438

All non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter".

@wxiaoguang @silverwind
@GiteaBot @denyskon
Make buttons in a modal form have proper type. (go-gitea#25446)
366f86b 
Fix  go-gitea#25438

All non-"ok" buttons which do not have "type" should not submit the
form, should not be triggered by "Enter".

Co-authored-by: silverwind <[email protected]>
Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 23, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 23, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 24, 2023
wxiaoguang
wxiaoguang approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legacy code in 1.20 looks really strange 🤣

I think I could propose a complete and transparent fix for all modals later.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@lunny lunny merged commit 050c38c into go-gitea:release/v1.20 Jun 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@denyskon denyskon deleted the backport-25446-v1.20 branch June 24, 2023 05:03
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Jun 24, 2023
@wxiaoguang
Revert "Make buttons in a modal form have proper type. (go-gitea#25446)…
4cf48db 
… (go-gitea#25478)"

This reverts commit 050c38c.
6543 pushed a commit that referenced this pull request Jun 24, 2023
@wxiaoguang
Revert "Make buttons in a modal form have proper type. (#25446) (#25478…
d1f1f11 
…)" (#25484)

There is a side effect because some modal doesn't have a proper "ok"
button.

This reverts commit 050c38c.
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 27, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@denyskon @lunny @wxiaoguang @GiteaBot @6543