When branch name contains # its throwing 404 from UI on clicking NewPullRequest button. #25844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… double encoding done in template and go template code.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
|
This issue may be required some other way to fix it. See the url its only encoded once on clicking on I need some feedback on this approach. |
puni9869
added
the
issue/needs-feedback
|
Duplicate, hence closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25830
Before
We use issue reference as branch name and when I pushed my branch, gitea suggested to create new pr, however "#" in the branch name breaks this feature !
After
Clicking on New Pull Request
