Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve clickable area in repo action view page #26115

Merged
merged 14 commits into from
Aug 15, 2023
Merged

Improve clickable area in repo action view page #26115

merged 14 commits into from
Aug 15, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jul 25, 2023 •
edited
Loading

Before:
image
After:
image

In current design, the clickable area is too small, and it is hard to find the correct clickable area as the area with background color (div with class name job-brief-item selected) is bigger than it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 25, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2023
delvh
delvh reviewed Jul 25, 2023
View reviewed changes
web_src/js/components/RepoActionView.vue Outdated
Comment on lines 35 to 36
<a class="job-brief-item" :href="run.link+'/jobs/'+index" :class="parseInt(jobIndex) === index ? 'selected' : ''" v-for="(job, index) in run.jobs" :key="job.id" @mouseenter="onHoverRerunIndex = job.id" @mouseleave="onHoverRerunIndex = -1">
<div class="job-brief-link">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div inside a is not allowed, if I'm not mistaken.

Copy link
Member

@silverwind silverwind Jul 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine. This was forbidden in HTML 4, but has since been relaxed with HTML 5. We already do it in a number of places like migration cards.

wxiaoguang
wxiaoguang reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is too dirty.

Before: <div class="job-brief-item"><a class="job-brief-link">

Now: <a class="job-brief-item"><div class="job-brief-link">

You can't only patch code without considering its meaning: why the div should use link's styles.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 29, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2023
@puni9869 puni9869 self-requested a review July 29, 2023 10:12
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jul 29, 2023
lunny
lunny previously requested changes Jul 29, 2023
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per #26115 (review)

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Aug 4, 2023

Renamed class name.

@yp05327 yp05327 requested a review from wxiaoguang August 7, 2023 05:01
wxiaoguang
wxiaoguang reviewed Aug 7, 2023
View reviewed changes
web_src/js/components/RepoActionView.vue Outdated
}

.job-brief-item .job-brief-link:hover {
.job-brief-item .job-brief-item-left:hover {
Copy link
Contributor

@wxiaoguang wxiaoguang Aug 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it needs to change styles for "div:hover"?

I think that's still the side effect of the blindly-renaming.

Before, it was a:hover, but you named them, div:hover doesn't make sense IMO.

@yp05327 yp05327 requested a review from lunny August 15, 2023 00:10
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Aug 15, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Aug 15, 2023

Ah, if I re-request review, the block status will be removed. 😕

@lunny lunny dismissed their stale review August 15, 2023 02:04

The problem resolved.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 15, 2023
@lunny lunny added this to the 1.21.0 milestone Aug 15, 2023
@silverwind silverwind merged commit 8703b6c into go-gitea:main Aug 15, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 15, 2023
@yp05327 yp05327 deleted the improve-job-select branch August 15, 2023 23:56
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 17, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
94e40c6 
* upstream/main:
  Sync repo's IsEmpty status correctly (go-gitea#26517)
  [skip ci] Updated translations via Crowdin
  Remove fomantic transition module (go-gitea#26469)
  Explain SearchOptions and fix ToSearchOptions (go-gitea#26542)
  Update go dependencies (go-gitea#26534)
  Differentiate better between user settings and admin settings (go-gitea#26538)
  Add missing triggers to update issue indexer (go-gitea#26539)
  Improve deadline icon location in milestone list page (go-gitea#26532)
  Use unique class for breadcrumb divider (go-gitea#26524)
  Fix typo of RunerOwnerID (go-gitea#26508)
  Improve clickable area in repo action view page (go-gitea#26115)
  Fix dark theme highlight for "NameNamespace" (go-gitea#26519)
  Remove duplicate CSS import for chroma/base.css (go-gitea#26523)
  Fix project filter bugs (go-gitea#26490)
  Fix display problems of members and teams unit (go-gitea#26363)
  Use `hidden` over `clip` for text truncation (go-gitea#26520)
  Add API route to list org secrets (go-gitea#26485)
  Set "type=button" for editor's toolbar buttons (go-gitea#26510)
  Apply to become a maintainer (go-gitea#26514)
  Detect ogg mime-type as audio or video (go-gitea#26494)
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 approved these changes

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
8 participants
@yp05327 @lunny @silverwind @wxiaoguang @delvh @puni9869 @GiteaBot @denyskon