Fix git hooks prompt

[CaiCandong]

close #26129

Before:

After:

[CaiCandong]

There is another bug here that can lead to the generation of dirty data: since Git operations rely on the creation of database PRs, when a Git operation fails, it's unable to roll back the changes in the database, resulting in the generation of dirty data.

Anyone have a good idea how to fix this bug?

• Screenshot
  
• Related code
  

  gitea/services/pull/pull.go

  Lines 53 to 75 in 983167c

  	if err := issues_model.NewPullRequest(ctx, repo, pull, labelIDs, uuids, pr); err != nil {
  	return err
  	}
  	for _, assigneeID := range assigneeIDs {
  	if err := issue_service.AddAssigneeIfNotAssigned(ctx, pull, pull.Poster, assigneeID); err != nil {
  	return err
  	}
  	}
  	pr.Issue = pull
  	pull.PullRequest = pr
  	// Now - even if the request context has been cancelled as the PR has been created
  	// in the db and there is no way to cancel that transaction we have to proceed - therefore
  	// create new context and work from there
  	prCtx, _, finished := process.GetManager().AddContext(graceful.GetManager().HammerContext(), fmt.Sprintf("NewPullRequest: %s:%d", repo.FullName(), pr.Index))
  	defer finished()
  	if pr.Flow == issues_model.PullRequestFlowGithub {
  	err = PushToBaseRepo(prCtx, pr)
  	} else {
  	err = UpdateRef(prCtx, pr)

[CaiCandong]

Anyone have a good idea how to fix this bug?

The bug will be fixed #26259

[wxiaoguang]

I do not think the UI is right.

[CaiCandong]

I do not think the UI is right.

The prompt message is from a user-set hook, which isn't very pretty, but giving a prompt is a little friendlier than the previous 500.

[wxiaoguang]

But there are full of HTML tags. Are these tags from the git hook?

[CaiCandong]

But there are full of HTML tags. Are these tags from the git hook?

HTML tags are not from a git hook, now I get what you're saying.

[CaiCandong]

I haven't figured out how this Flash works.，why I only get network errors with the following function？@zeripath

ctx.Flash.Error(flashError, true)

[yp05327]

I think we can not use Flash error here, we should use JSONError and handling the msg by js.
But we are using tippy to show this error msg which can not render html code correctly,
and we need do more changes as the comment said here:

gitea/web_src/js/features/common-global.js

Line 122 in a370efc

// TODO: use a better toast UI instead of the tippy. If the form height is large, the tippy position is not good

[silverwind]

The toast module may be more suitable, but it currently also escapes HTML for security reason. If we are sure there is nothing user-supplied in these messages, we could add an option to disable HTML escaping. Same is also possible for Tippy, but generally I'm wary because the screenshot above does show it contains user data.

https://github.com/go-gitea/gitea/blob/main/web_src/js/modules/toast.js

[yp05327]

Maybe we can remove Details in the error message?
Then using toast will not cause security problems.

ps: Did #26259 fully fix #26129? #26129 is closed now.