add some Wiki unit tests #26260
Merged
add some Wiki unit tests #26260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Just to get 100% coverage on services/wiki/wiki_path.go, nothing special. This is just an formality. (cherry picked from commit 6b3528920fbf18c41d6aeb95498af48443282370) Refs: https://codeberg.org/forgejo/forgejo/pulls/1156
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
delvh
approved these changes
Aug 1, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Aug 1, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
puni9869
reviewed
Aug 1, 2023
| func TestWebPathFromRequest(t *testing.T) { | ||
| assert.Equal(t, WebPath("a%2Fb"), WebPathFromRequest("a/b")) | ||
| assert.Equal(t, WebPath("a"), WebPathFromRequest("a")) | ||
| assert.Equal(t, WebPath("b"), WebPathFromRequest("a/../b")) |
There was a problem hiding this comment.
can you add more assert on WebPath("a%23123") --> a#123 if not in this PR then a followup PR.
puni9869
approved these changes
Aug 1, 2023
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 3, 2023
* upstream/main: Make confusable character warning less jarring (go-gitea#25069) Update Gmail example (go-gitea#26302) Fix the topic validation rule and suport dots (go-gitea#26286) Upgrade x/net to 0.13.0 (go-gitea#26297) add unit test for user renaming (go-gitea#26261) add some Wiki unit tests (go-gitea#26260)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 6b3528920fbf18c41d6aeb95498af48443282370)
Refs: https://codeberg.org/forgejo/forgejo/pulls/1156