Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap highlighting between tags and branches #26577

Closed
wants to merge 1 commit into from
Closed

Swap highlighting between tags and branches #26577

wants to merge 1 commit into from

Conversation

CaiCandong
Copy link
Member

In the dropdown box, the color when selected is black instead of highlighted, which seems a bit strange.

  • Before:
  • After:

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 18, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Aug 18, 2023 •
edited
Loading

It's still strange. I think it could just follow GitHub's solution.

@silverwind
Copy link
Member

silverwind commented Aug 18, 2023 •
edited
Loading

Agree, link color is strange to indicate "active tab". Previously it showed that the inactive tab is clickable with the color, which made more sense than this imho.

Preferably we should render actual tabs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 18, 2023
silverwind
silverwind requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking, current change is a regression. Color is meant to show clickability, not active tab. Real tabs would be preferred.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 18, 2023
@yp05327
Copy link
Contributor

yp05327 commented Aug 21, 2023

[WIP] Maybe we need something like this:
image

@CaiCandong
Copy link
Member Author

[WIP] Maybe we need something like this: image

We need a tabs component, but I'm not very familiar with Vue.js, can anyone propose a new PR to replace this?
image

@CaiCandong CaiCandong closed this Aug 21, 2023
@wxiaoguang
Copy link
Contributor

-> Improve the branch selector tab UI #26631

@CaiCandong CaiCandong deleted the Swap-highlight-between-tags-and-branches branch September 4, 2023 12:40
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind requested changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CaiCandong @wxiaoguang @silverwind @yp05327 @delvh @GiteaBot