Improve show role #26621
Merged
Improve show role #26621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
yp05327
force-pushed
the
improve-show-role
branch
from
3c15413 to
cddba67
Compare
lunny
approved these changes
Aug 21, 2023
GiteaBot
added
lgtm/need 1
delvh
added
the
type/refactoring
delvh
approved these changes
Aug 21, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wxiaoguang
previously requested changes
Aug 21, 2023
GiteaBot
added
lgtm/blocked
wxiaoguang
removed
the
reviewed/wait-merge
Done. |
wxiaoguang
reviewed
Aug 22, 2023
| </div> | ||
| {{end}} | ||
| {{if (.Issue.ShowRole.HasRole "Owner")}} | ||
| <div class="ui basic label role-label"> |
There was a problem hiding this comment.
There were "role-label" classes, they are lost now?
There was a problem hiding this comment.
Only in this place have role-label class, didn't understand the usage here, but I understand the usage of role-label now: hide them in mobiles.
In GitHub will not display role label in mobiles, so we can add this in the general template.
In Gitea:
After:
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Aug 22, 2023
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 22, 2023
* upstream/main: Improve show role (go-gitea#26621) Improve some flex layouts (go-gitea#26649) feat: implement organization secret creation API (go-gitea#26566) Check disabled workflow when rerun jobs (go-gitea#26535)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a general show role template.