Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed text overflow in dropdown menu #26694

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Fixed text overflow in dropdown menu #26694

merged 5 commits into from
Aug 25, 2023

Conversation

POPSuL
Copy link
Contributor

@POPSuL POPSuL commented Aug 23, 2023

Fixes #26622

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 23, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2023
@POPSuL POPSuL changed the title Fixed text overflow in dropdown menu (#26622) Fixed text overflow in dropdown menu Aug 23, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Aug 23, 2023 •
edited
Loading

Changing the default .item class doesn't seem ideal (even more, .ui.menu .ui.dropdown.item .menu .item doesn't seem the reasonable selector).

The whole story is:

  1. The dropdown auto adjust its width by item width by default.
  2. But, the .repository .dropdown has max-width: ...
  3. To work with max-width: ..., either:
    1. Add the "overflow control" to .repository .filter.menu .ui.dropdown .menu items
    2. -OR- Wrap the item text with class="gt-ellipsis" in the dropdown with max-width

@POPSuL
Copy link
Contributor Author

POPSuL commented Aug 23, 2023

@wxiaoguang overflow control now applied only for repository filters and it also fixes behavior of gt-ellipsis on other filters which not working actually.
image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 24, 2023
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Aug 24, 2023
@lunny lunny added this to the 1.21.0 milestone Aug 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 24, 2023
@silverwind silverwind enabled auto-merge (squash) August 25, 2023 11:08
@silverwind silverwind merged commit 7b05d66 into go-gitea:main Aug 25, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 25, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 27, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
130bf51 
* upstream/main:
  Move `modules/mirror` to `services` (go-gitea#26737)
  [skip ci] Updated translations via Crowdin
  Fix template bugs in recently_pushed_new_branches.tmpl (go-gitea#26744)
  Fix incorrect "tabindex" attributes (go-gitea#26733)
  Simplify helper CSS classes and avoid abuse (go-gitea#26728)
  Remove fomantic loader module (go-gitea#26670)
  Fix link in mirror docs (go-gitea#26719)
  Add `eslint-plugin-vue-scoped-css` (go-gitea#26720)
  Fixed text overflow in dropdown menu (go-gitea#26694)
  Make web context initialize correctly for different cases (go-gitea#26726)
  Remove incorrect CSS helper classes (go-gitea#26712)
  Focus editor on "Write" tab click (go-gitea#26714)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denyskon denyskon denyskon approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Milestones with long names in the issue filter list
6 participants
@POPSuL @wxiaoguang @denyskon @lunny @silverwind @GiteaBot