Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS NPE when viewing specific range of PR commits (#27912) #27923

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Nov 6, 2023

Backport #27912 by @delvh

This should be the easiest fix.
While other solutions might be possible that exterminate the root cause, they will not be as trivial.

This should be the easiest fix.
While other solutions might be possible that exterminate the root cause,
they will not be as trivial.
@GiteaBot GiteaBot added modifies/frontend topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/bug labels Nov 6, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Nov 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 6, 2023
@lunny lunny enabled auto-merge (squash) November 6, 2023 09:17
@lunny lunny merged commit 49f82ac into go-gitea:release/v1.21 Nov 6, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 6, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants