Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary forgot password link in delete user section #28355

Merged

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Dec 5, 2023

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2023
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 5, 2023
@n0toose
Copy link
Contributor

n0toose commented Dec 5, 2023

I previously assumed that the context of that button being there is people creating new accounts, staying logged in and then deleting them because they cannot remember their previous password (which is needed in order to change their password).

@lunny
Copy link
Member

lunny commented Dec 5, 2023

It's near the password input box. So maybe users forget the password, they can click the link. Why do you think it's unnecessary?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 5, 2023

It's very unusual to have that link in your profile. If you don't know your password, you should not be logged in or you would change it in the settings.

@yp05327
Copy link
Contributor Author

yp05327 commented Dec 5, 2023

image

There's already a forget password above.

@lunny
Copy link
Member

lunny commented Dec 6, 2023

image

There's already a forget password above.

Yes, because there are two password input boxes.

@lunny
Copy link
Member

lunny commented Dec 6, 2023

It's very unusual to have that link in your profile. If you don't know your password, you should not be logged in or you would change it in the settings.

If that, we should remove both of the links.

@yp05327
Copy link
Contributor Author

yp05327 commented Dec 7, 2023

If you don't know your password, you should not be logged in.

If you use third party to login, for example, I usually use GitHub account to login into gitea.com,
you can be logged in without password.

@delvh
Copy link
Member

delvh commented Dec 15, 2023

So, overall, let's just remove the duplicate one as currently suggested.
We can still argue later on about whether to remove the second one too.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 15, 2023
@lunny lunny enabled auto-merge (squash) December 15, 2023 13:40
@lunny lunny merged commit 3849fd2 into go-gitea:main Dec 15, 2023
24 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 15, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 15, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 16, 2023
* upstream/main:
  Update docs for DISABLE_QUERY_AUTH_TOKEN (go-gitea#28485)
  Improve CLI code and descriptions (go-gitea#28482)
  Remove unnecessary forgot password link in delete user section (go-gitea#28355)
@yp05327 yp05327 deleted the remove-forgot-password-in-delete-user-account branch February 1, 2024 00:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants