Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable admin to search by email #2888

Merged
merged 2 commits into from
Nov 26, 2017

Conversation

ethantkoenig
Copy link
Member

Allow admins to search for users by email.

@codecov-io
Copy link

codecov-io commented Nov 11, 2017

Codecov Report

Merging #2888 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2888      +/-   ##
=========================================
- Coverage    26.8%   26.8%   -0.01%     
=========================================
  Files          90      90              
  Lines       17807   17810       +3     
=========================================
  Hits         4774    4774              
- Misses      12353   12355       +2     
- Partials      680     681       +1
Impacted Files Coverage Δ
models/user.go 21.87% <50%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061c501...baf3e5a. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 11, 2017
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Nov 12, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 12, 2017
@lunny
Copy link
Member

lunny commented Nov 26, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2017
@lafriks
Copy link
Member

lafriks commented Nov 26, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2017
@lunny lunny merged commit 716ac12 into go-gitea:master Nov 26, 2017
@ethantkoenig ethantkoenig deleted the admin_search_by_email branch December 18, 2017 06:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants