Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swift packages not resolving #29095

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix swift packages not resolving #29095

merged 1 commit into from
Feb 8, 2024

Conversation

CEnnis91
Copy link
Contributor

@CEnnis91 CEnnis91 commented Feb 8, 2024

Fixes #29094

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Feb 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2024
@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Feb 8, 2024
@lunny lunny added this to the 1.22.0 milestone Feb 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2024
@lunny lunny merged commit 6be3fda into go-gitea:main Feb 8, 2024
25 checks passed
@GiteaBot
Copy link
Collaborator

GiteaBot commented Feb 8, 2024

I was unable to create a backport for 1.21. @CEnnis91, please send one manually. 🍵

go run ./contrib/backport 29095
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 8, 2024
@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 8, 2024

https://github.com/apple/swift-package-manager/blob/main/Documentation/Registry.md#endpoint-2 still says this field is called id.

@CEnnis91
Copy link
Contributor Author

CEnnis91 commented Feb 8, 2024

https://github.com/apple/swift-package-manager/blob/main/Documentation/Registry.md#endpoint-2 still says this field is called id.

This link 404s for me. It used to be at that path but was moved.

Unless I'm misunderstanding, there is an id field at the base of the struct, but the name field inside resources is the issue: https://github.com/apple/swift-package-manager/blob/main/Documentation/PackageRegistry/Registry.md#421-package-release-resources

CEnnis91 added a commit to CEnnis91/gitea that referenced this pull request Feb 8, 2024
@CEnnis91
Fix swift packages not resolving (go-gitea#29095)
9df09ed 
Backport go-gitea#29095

Fixes go-gitea#29094
@CEnnis91 CEnnis91 mentioned this pull request Feb 8, 2024
Merged
@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 8, 2024

Here is the correct link:
https://github.com/apple/swift-package-manager/blob/main/Documentation/PackageRegistry/Registry.md#endpoint-2

Thanks for the explanation, I see now where my typo was.

jolheiser pushed a commit that referenced this pull request Feb 8, 2024
@CEnnis91
Fix swift packages not resolving (#29095) (#29102)
1aaeec6
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@CEnnis91 @silverwind
Fix swift packages not resolving (go-gitea#29095)
cbfe005 
Fixes go-gitea#29094
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Feb 21, 2024
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@CEnnis91 @earl-warren
[gitea] Fix swift packages not resolving (go-gitea#29095)
e87ab05 
Fixes go-gitea#29094

(cherry picked from commit 6be3fda)
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sillyguodong sillyguodong sillyguodong approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/packages type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Swift fails to resolve from package registry
6 participants
@CEnnis91 @GiteaBot @KN4CK3R @lunny @sillyguodong @wxiaoguang