Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use general token signing secret #29205

Merged
merged 7 commits into from
Feb 18, 2024
Merged

Use general token signing secret #29205

merged 7 commits into from
Feb 18, 2024

Conversation

wxiaoguang
Copy link
Contributor

Use a clearly defined "signing secret" for token signing.

@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 17, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Feb 17, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 17, 2024
lunny
lunny reviewed Feb 17, 2024
View reviewed changes
modules/setting/oauth2.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2024
6543
6543 reviewed Feb 17, 2024
View reviewed changes
modules/setting/oauth2.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2024
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 18, 2024
@6543 6543 enabled auto-merge (squash) February 18, 2024 17:14
@6543 6543 merged commit 8be198c into go-gitea:main Feb 18, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 18, 2024
@6543 6543 added the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 18, 2024
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.21. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 29205
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 18, 2024
@wxiaoguang wxiaoguang deleted the refactor-jwt branch February 19, 2024 01:47
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Feb 20, 2024
@wxiaoguang @Gusted
Port "Use general token signing secret"
62d3e52 
Port of go-gitea/gitea#29205

Use a clearly defined "signing secret" for token signing.

(cherry picked from commit 8be198cdef0a486f417663b1fd6878458d7e5d92)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Use general token signing secret (go-gitea#29205)
27f712b 
Use a clearly defined "signing secret" for token signing.
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Feb 22, 2024
@wxiaoguang
Use general token signing secret (go-gitea#29205)
c8d2f25
@wxiaoguang wxiaoguang mentioned this pull request Feb 22, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 22, 2024
lunny pushed a commit that referenced this pull request Feb 22, 2024
@wxiaoguang
Use general token signing secret (#29205) (#29325)
511298e 
Backport #29205 (including #29172)

Use a clearly defined "signing secret" for token signing.
@6543 6543 added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Feb 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@KN4CK3R KN4CK3R KN4CK3R left review comments

@delvh delvh delvh approved these changes

@wolfogre wolfogre wolfogre approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
7 participants
@wxiaoguang @GiteaBot @lunny @KN4CK3R @wolfogre @6543 @delvh