2939 multiline commit message

[makarchuk]

View of multiline commit messages as tooltips.
Fixes #2939

[codecov-io]

Codecov Report

Merging #2944 into master will decrease coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2944      +/-   ##
==========================================
- Coverage   27.24%   26.82%   -0.42%     
==========================================
  Files          89       90       +1     
  Lines       17640    17807     +167     
==========================================
- Hits         4806     4777      -29     
- Misses      12146    12351     +205     
+ Partials      688      679       -9

Impacted Files	Coverage Δ
models/issue_list.go	50.6% <0%> (-12.45%)	⬇️
models/webhook.go	46.9% <0%> (-0.91%)	⬇️
models/issue_indexer.go	7.79% <0%> (-0.32%)	⬇️
models/error.go	18.62% <0%> (-0.31%)	⬇️
routers/user/setting.go	0% <0%> (ø)	⬆️
models/webhook_dingtalk.go	0% <0%> (ø)
modules/process/manager.go	73.91% <0%> (+4.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6c198...ac18b53. Read the comment docs.

[lafriks]

Also title should be added page.tmpl element <h3> where commit message is rendered

[lafriks]

Quotes seems to be missing

[makarchuk]

I added the quotes and title in page.tmpl

[lafriks]

It still seems strange to me that attribute value contains newlines. It needs to be verified that it works on all supported browsers

[makarchuk]

If it helps: These are my screenshots from chrome and Firefox (newest versions both) on my ubuntu

[lafriks]

Yes on these were also I tested :) I'm more worried about Safari and IE on windows. These are usually the most problematic ones

[sondr3]

I don't really like the idea of viewing multiline commits in a tooltip, both GitHub and GitLab show multiline commits with a ... button you press to expand the commit message into full view. First off it makes viewing the history harder if you want to open multiple commits and view their messages, you can't easily copy commit messages or potential names or emails from contributor/whoever signed off on the commit and the discoverability is poor, I would never consider hovering over commit messages to get the full body in a tooltip, if it was a multiline commit I'd expect there to be some kind of sign that enables me to view the full message.

[makarchuk]

I can try and implement this, but I'm new to a project, so I might need some guidance.
I haven't found any information on how we cook JS. Is it just good old JQuery(So I can just modify in project files and it'll be all good) or some kind of fancy modern framework?
Is it acceptable to use onclick on HTML elements or I should use jq $('SELECTORHERE').click(...)?

[lunny]

@makarchuk you can use vue.js

[sondr3]

I'd love to help but I'm in the middle of all my exams for this semester, I can help over Christmas if this is still open 😃

[lafriks]

@sondr3 jQuery for this would be ok

[sondr3]

I've created my own version of multiline commits in #2980, but the implementation is very rough and not finished, I'd love if any of you would give me a helping hand.

[sondr3]

My own version is now done (or so I hope), if any of you would like to test it I'd really appreciate it.

[lafriks]

Closing this as other PR has implemented this with expandable button