Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contrast on blame timestamp, fix double border (#29482) #29485

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Improve contrast on blame timestamp, fix double border (#29482) #29485

merged 2 commits into from
Feb 29, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #29482 by @silverwind

Before, double border on top, bad contrast on dark:
Screenshot 2024-02-29 at 02 06 17
Screenshot 2024-02-29 at 02 07 28

After, no double border on top, good contrast:
Screenshot 2024-02-29 at 02 20 20
Screenshot 2024-02-29 at 02 20 38

@silverwind @GiteaBot
Improve contrast on blame timestamp, fix double border (go-gitea#29482)
23d737f 
Before, double border on top, bad contrast on dark:
<img width="155" alt="Screenshot 2024-02-29 at 02 06 17"
src="https://github.com/go-gitea/gitea/assets/115237/fc0f1e08-a5ce-47ed-9eb6-135eed5a1abb">
<img width="126" alt="Screenshot 2024-02-29 at 02 07 28"
src="https://github.com/go-gitea/gitea/assets/115237/38ae8483-8d9b-484c-8909-d4466131ea16">

After, no double border on top, good contrast:
<img width="154" alt="Screenshot 2024-02-29 at 02 20 20"
src="https://github.com/go-gitea/gitea/assets/115237/ad91282b-e9f5-4f41-8f5e-6ba28db3beac">
<img width="147" alt="Screenshot 2024-02-29 at 02 20 38"
src="https://github.com/go-gitea/gitea/assets/115237/7ee2ec92-e72a-4981-aec3-98fc8e579bae">
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 29, 2024
@GiteaBot GiteaBot added this to the 1.21.8 milestone Feb 29, 2024
@GiteaBot GiteaBot requested review from lafriks and lunny February 29, 2024 02:00
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 29, 2024
@lafriks lafriks enabled auto-merge (squash) February 29, 2024 08:47
@lafriks lafriks merged commit 65b9ffe into go-gitea:release/v1.21 Feb 29, 2024
27 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@lafriks lafriks Awaiting requested review from lafriks

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.21.8
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @lunny @KN4CK3R @silverwind @lafriks