Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit-Dropdown: Show Author of commit if available (#30272) #30285

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Commit-Dropdown: Show Author of commit if available (#30272) #30285

merged 1 commit into from
Apr 5, 2024

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Apr 5, 2024

Backport #30272 by @sebastian-sauer

As in commits page we show the author of the commit in the commits dropdown and not the committer.

Commits Page:
Screenshot from 2024-04-03 22-34-41

and the same contents in our dropdown:
image

fixes #29588

@sebastian-sauer @GiteaBot
Commit-Dropdown: Show Author of commit if available (go-gitea#30272)
0ed47e5 
As in commits page we show the author of the commit in the commits
dropdown and not the committer.

Commits Page:
![Screenshot from 2024-04-03
22-34-41](https://github.com/go-gitea/gitea/assets/1135157/1c7c5c19-6d0a-4176-8a87-7bca6a0c6dc8)

and the same contents in our dropdown:

![image](https://github.com/go-gitea/gitea/assets/1135157/aa094af2-c369-47ac-9c27-ca208d1d03f0)


fixes go-gitea#29588
@GiteaBot GiteaBot added the modifies/go Pull requests that update Go code label Apr 5, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 5, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 5, 2024
@GiteaBot GiteaBot requested review from delvh and silverwind April 5, 2024 00:52
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 5, 2024
@silverwind silverwind enabled auto-merge (squash) April 5, 2024 00:59
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2024
@silverwind silverwind merged commit c8570b7 into go-gitea:release/v1.22 Apr 5, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @silverwind @a1012112796 @sebastian-sauer