Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if reverse proxy is correctly configured #30890

Merged
merged 4 commits into from
May 10, 2024
Merged

Check if reverse proxy is correctly configured #30890

merged 4 commits into from
May 10, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 7, 2024 •
edited
Loading

Follow #27011
Follow #30885

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 7, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2024
@wxiaoguang wxiaoguang marked this pull request as draft May 7, 2024 08:49
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/js labels May 7, 2024
@wxiaoguang wxiaoguang changed the title Check if reverse proxy is correctly configured WIP: Check if reverse proxy is correctly configured May 7, 2024
@wxiaoguang wxiaoguang mentioned this pull request May 7, 2024
Closed
@wxiaoguang wxiaoguang marked this pull request as ready for review May 7, 2024 09:39
@wxiaoguang wxiaoguang changed the title WIP: Check if reverse proxy is correctly configured Check if reverse proxy is correctly configured May 7, 2024
@wxiaoguang wxiaoguang mentioned this pull request May 7, 2024
Merged
@wxiaoguang wxiaoguang force-pushed the fix-error-detection branch from 10c1665 to d0f432f Compare May 7, 2024 09:40
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2024
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code labels May 7, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 7, 2024
silverwind
silverwind reviewed May 7, 2024
View reviewed changes
web_src/js/bootstrap.js Outdated Show resolved Hide resolved
@wxiaoguang wxiaoguang added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 9, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 10, 2024
@wxiaoguang wxiaoguang merged commit 7424f27 into go-gitea:main May 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 10, 2024
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request May 10, 2024
@wxiaoguang @silverwind @GiteaBot
Check if reverse proxy is correctly configured (go-gitea#30890)
376309c 
Follow go-gitea#27011
Follow go-gitea#30885

---------

Co-authored-by: silverwind <[email protected]>
Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot mentioned this pull request May 10, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 10, 2024
@wxiaoguang wxiaoguang deleted the fix-error-detection branch May 10, 2024 12:07
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 10, 2024
wxiaoguang added a commit that referenced this pull request May 10, 2024
@GiteaBot @wxiaoguang @silverwind
Check if reverse proxy is correctly configured (#30890) (#30935)
b99473f 
Backport #30890 by wxiaoguang

Follow #27011
Follow #30885

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: silverwind <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 13, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ad89474 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix file path width in repo non-homepage view (go-gitea#30951)
  Enable `declaration-block-no-redundant-longhand-properties` (go-gitea#30950)
  [skip ci] Updated translations via Crowdin
  Move reverproxyauth before session so the header will not be ignored even if user has login (go-gitea#27821)
  Use CSS `inset` shorthand (go-gitea#30939)
  Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (go-gitea#30894)
  Update JS dependencies, add new eslint rules (go-gitea#30840)
  Fix some UI regressions for commit list (go-gitea#30920)
  Forbid deprecated `break-word` in CSS (go-gitea#30934)
  Check if reverse proxy is correctly configured (go-gitea#30890)
  Remove deprecated stuff for runners (go-gitea#30930)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/js modifies/templates This PR modifies the template files modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot