fix button heights on commits page #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3091 +/- ##
==========================================
- Coverage 33.25% 33.25% -0.01%
==========================================
Files 273 273
Lines 39954 39954
==========================================
- Hits 13288 13286 -2
- Misses 24767 24769 +2
Partials 1899 1899
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
LGTM |
tboerger
added
lgtm/need 1
|
@silverwind if this change will effect other menus? |
|
It will, but there should be no negative effect. You can see the override as sort of a bug fix for a bug in Semantic. |
silverwind
added a commit
to silverwind/Semantic-UI
that referenced
this pull request
Dec 5, 2017
When `.button` is not a direct descendant of `.menu` (for example, when it is wrapped), it would not get this style applied, which caused inconsistent heights of buttons that were wrapped vs. ones that weren't. Removed the `>` operator to fix this. Refs: - go-gitea/gitea#3091 - https://try.gitea.io/silverwind/testcopy/commits/branch/master
|
I also created Semantic-Org/Semantic-UI#5996 to fix this in Semantic itself. Thought, based on the recent activity in that repo, I don't see that one getting merged anytime soon. |
|
LGTM |
tboerger
added
lgtm/done
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a issue I introduced by changing the branch button. Basically, Semantic uses the selector
.ui.menu:not(.vertical) .item > .buttonwhich does not work if.buttonis no direct child of.itemwhich is the case for the branch button in our case, because it's wrapped in a dropdown.Additionally, I fixed a indendation issue I introduced earlier while merging.
Before
After