-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor struct's time to remove unnecessary memory usage #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Dec 11, 2017
appleboy
approved these changes
Dec 11, 2017
LGTM |
tboerger
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Dec 11, 2017
Codecov Report
@@ Coverage Diff @@
## master #3142 +/- ##
=========================================
+ Coverage 34.66% 34.77% +0.1%
=========================================
Files 275 276 +1
Lines 40030 39945 -85
=========================================
+ Hits 13878 13889 +11
+ Misses 24173 24058 -115
- Partials 1979 1998 +19
Continue to review full report at Codecov.
|
LGTM |
tboerger
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Dec 11, 2017
This was referenced Dec 11, 2017
7 tasks
daviian
added a commit
to daviian/gitea
that referenced
this pull request
Jun 9, 2018
lunny
pushed a commit
that referenced
this pull request
Jun 10, 2018
daviian
added a commit
to daviian/gitea
that referenced
this pull request
Jun 10, 2018
lafriks
pushed a commit
that referenced
this pull request
Jun 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove unnecessary time.Time on almost all the structs and define a new time
type TimeStamp int64
to handle the time. It's also improve theTimeSince
where converted totime.Time
and convert back before. So that, manyBeforeInsert
andAfterLoad
is still unnecessary. The code is more clean.