Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for LOG_COMPRESSION in ini #31809

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Fix typo for LOG_COMPRESSION in ini #31809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb1d7db
chore: fix typo for `LOG_COMPRESSION` in ini
wolfogre Aug 9, 2024
b1c52bf
Update custom/conf/app.example.ini
wolfogre Aug 9, 2024
13d419a
Merge branch 'main' into bugfix/log_compression_typo
lunny Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom/conf/app.example.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2688,7 +2688,7 @@ LEVEL = Info
;; Logs retention time in days. Old logs will be deleted after this period.
;LOG_RETENTION_DAYS = 365
;; Log compression type, `none` for no compression, `zstd` for zstd compression.
;; Other compression types like `gzip` if NOT supported, since seekable stream is required for log view.
;; Other compression types like `gzip` are NOT supported, since seekable stream is required for log view.
;; It's always recommended to use compression when using local disk as log storage if CPU or memory is not a bottleneck.
;; And for object storage services like S3, which is billed for requests, it would cause extra 2 times of get requests for each log view.
;; But it will save storage space and network bandwidth, so it's still recommended to use compression.
Expand Down