Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :focus-visible style to buttons (#31799) #31819

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Add :focus-visible style to buttons (#31799) #31819

merged 1 commit into from
Aug 12, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #31799 by @silverwind

Buttons now show a focus style via :focus-visible when the browser deems the focus to be important, like for example when the button is focused via keyboard navigation.

Screenshot 2024-08-07 at 22 12 51 image

@silverwind @GiteaBot
Add :focus-visible style to buttons (go-gitea#31799)
34b4c77 
Buttons now show a focus style via
[`:focus-visible`](https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible)
when the browser deems the focus to be important, like for example when
the button is focused via keyboard navigation.

<img width="492" alt="Screenshot 2024-08-07 at 22 12 51"
src="https://github.com/user-attachments/assets/060568b1-1599-4c56-bafb-b36ebb1bec35">
<img width="479" alt="image"
src="https://github.com/user-attachments/assets/885f4e10-f496-47f0-8ae5-45827ded09f8">
@GiteaBot GiteaBot added topic/accessibility This issue/pull request wants to improve the accessibility topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality labels Aug 12, 2024
@GiteaBot GiteaBot requested a review from denyskon August 12, 2024 00:40
@GiteaBot GiteaBot added this to the 1.22.2 milestone Aug 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 12, 2024
@GiteaBot GiteaBot requested a review from lunny August 12, 2024 00:40
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 12, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 12, 2024
@lunny lunny merged commit f6f2349 into go-gitea:release/v1.22 Aug 12, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denyskon denyskon denyskon approved these changes

@lunny lunny lunny approved these changes

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/accessibility This issue/pull request wants to improve the accessibility topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.2
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @denyskon @silverwind