Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CloseIssue and ReopenIssue instead of ChangeStatus #32467

Merged
merged 17 commits into from
Dec 25, 2024
Merged

Use CloseIssue and ReopenIssue instead of ChangeStatus #32467

merged 17 commits into from
Dec 25, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 10, 2024 •
edited
Loading

The behaviors of closing issues and reopening issues are very different. So splitting it into two different functions makes it easier to maintain.

  • Split ChangeIssueStatus into CloseIssue and ReopenIssue both at service layer and model layer
  • Rename isClosed to CloseOrReopen to make it more readable.
  • Add transactions for ReopenIssue and CloseIssue

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 10, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 10, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 10, 2024
Zettat123
Zettat123 reviewed Nov 24, 2024
View reviewed changes
routers/api/v1/repo/issue.go Outdated Show resolved Hide resolved
routers/web/repo/issue_list.go Outdated Show resolved Hide resolved
@lunny lunny requested a review from Zettat123 December 17, 2024 00:19
Zettat123
Zettat123 reviewed Dec 17, 2024
View reviewed changes
models/issues/issue_update.go Outdated Show resolved Hide resolved
services/issue/status.go Outdated Show resolved Hide resolved
models/issues/dependency_test.go Show resolved Hide resolved
@lunny lunny added this to the 1.24.0 milestone Dec 18, 2024
Zettat123
Zettat123 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Zettat123 Zettat123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except CI error

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2024
@delvh delvh changed the title Use CloseIssue and ReopenIssue instead of ChagneStatus for issues Use CloseIssue and ReopenIssue instead of ChangeStatus Dec 18, 2024
@lunny
Copy link
Member Author

lunny commented Dec 25, 2024

Last call for one more review. @go-gitea/technical-oversight-committee

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 25, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 25, 2024
@lunny lunny enabled auto-merge (squash) December 25, 2024 07:24
@lunny lunny merged commit 5feb1a6 into go-gitea:main Dec 25, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 25, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 26, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0fb6f40 
* giteaofficial/main:
  Do not render truncated links in markdown (go-gitea#32980)
  Use `CloseIssue` and `ReopenIssue` instead of `ChangeStatus` (go-gitea#32467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiifong hiifong hiifong approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @Zettat123 @hiifong @GiteaBot