Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable gravatar in test #32529

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

bohde
Copy link
Contributor

@bohde bohde commented Nov 15, 2024

When running e2e tests on flaky networks, gravatar can cause a timeout and test failures. Turn off, and populate avatars on e2e test suite run to make them reliable.

When running e2e tests on flaky networks, gravatar can cause a timeout
and test failures. Turn off, and populate avatars on run to make tests
more reliable.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 15, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 15, 2024
tests/e2e/e2e_test.go Outdated Show resolved Hide resolved
@bohde bohde marked this pull request as ready for review November 20, 2024 19:29
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2024
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So clear! Thank you.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2024
@lunny lunny enabled auto-merge (squash) November 21, 2024 03:09
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2024
@lunny lunny merged commit 9ac74a1 into go-gitea:main Nov 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 21, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2024
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Nov 21, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2024
* giteaofficial/main:
  Add line-through for deleted branch on pull request view page (go-gitea#32500)
  Fix issue sidebar regression (go-gitea#32598)
  Fix PR diff review form submit (go-gitea#32596)
  Fix some typescript issues (go-gitea#32586)
  Fix GetInactiveUsers (go-gitea#32540)
  disable gravatar in test (go-gitea#32529)
  Add 'Copy path' button to file view (go-gitea#32584)
  Improve issue sidebar UI (go-gitea#32587)
  Supplement and Improvement for go-gitea#32558 (go-gitea#32585)
  make search box in issue sidebar dropdown list always show when scrolling (go-gitea#32576)
  Fix submodule parsing (go-gitea#32571)
  allow the actions user to login via the jwt token (go-gitea#32527)
  Support HTTP POST requests to `/userinfo`, aligning to OpenID Core specification (go-gitea#32578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants