Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor find forks and fix possible bugs that weak permissions check (#32528) #32546

Closed

Conversation

GiteaBot
Copy link
Collaborator

Backport #32528 by @lunny

  • Move models/GetForks to services/FindForks
  • Add doer as a parameter of FindForks to check permissions
  • Slight performance optimization for get forks API with batch loading of repository units
  • Add tests for forking repository to organizations

…go-gitea#32528)

- Move models/GetForks to services/FindForks
- Add doer as a parameter of FindForks to check permissions
- Slight performance optimization for get forks API with batch loading
of repository units
- Add tests for forking repository to organizations

---------

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Nov 18, 2024
@GiteaBot GiteaBot added this to the 1.22.4 milestone Nov 18, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2024
@lunny
Copy link
Member

lunny commented Nov 18, 2024

replaced by #32547

@lunny lunny closed this Nov 18, 2024
@GiteaBot GiteaBot removed this from the 1.22.4 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants