Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show tag name on branch/tag selector if repo shown from tag ref #32689

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: show tag name on branch/tag selector if repo shown from tag ref #32689

merged 1 commit into from
Dec 2, 2024

Conversation

metiftikci
Copy link
Member

This is what i tried to say in #32681 (comment) but sadly in wrong place

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 2, 2024
wxiaoguang
wxiaoguang approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you very much.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 2, 2024 13:16
@wxiaoguang wxiaoguang merged commit 2824ae2 into go-gitea:main Dec 2, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 2, 2024
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Dec 2, 2024
@metiftikci metiftikci deleted the fix-branch-dropdown branch December 2, 2024 16:28
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 3, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
948d5ea 
* giteaofficial/main:
  Add "View all branches/tags" entry to Branch Selector (go-gitea#32653)
  Remove all "floated" CSS styles (go-gitea#32691)
  Optimize the styling of icon buttons within file-header-right (go-gitea#32675)
  fix: show tag name on branch/tag selector if repo shown from tag ref (go-gitea#32689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@metiftikci @wxiaoguang @Zettat123 @GiteaBot